Enable CI builds for *10 distros and also on arm64 runners #241
Conversation
This is no longer supported with: * RHEL 10 * CentOS Stream 10 * Rocky Linux 10 ...and also not needed anymore when checking the current GSI-OpenSSH sources. Also see gridcf#234.
plus white space cleanup in original workflow file
|
I already tested this locally in my fork of the GCT and it worked for me after some trial and error. So I assume it will also work here, let's see... |
|
...well, unless package data is in an inconsistent state, like for https://github.com/gridcf/gct/actions/runs/19429781076/job/55585691152?pr=241 - or could be an error on GHA side, as the other Rocky Linux 9 build didn't error out so far. |
|
Oh yeah, nearly forgot about this fact: The ARM64 builds are configured do not upload releases packages. This is only done for the regular x86_64 builds in case of the creation of a (release) tag. |
msalle
left a comment
msalle
left a comment
There was a problem hiding this comment.
In general it looks pretty straightforward, especially if you have tested it.
See my one comment though.
|
I'll try to restart that one failing test, assuming it will work through now... |
...and it did this time, so only a temporary error. |
|
Memo: If this PR gets merged instead of #240 and this PR, when making the merge, please combine both titles and descriptions for the merge commit, e.g. like: Enable CI builds for *10 distros and also on arm64 runners
|
fscheiner
changed the title
msalle
left a comment
msalle
left a comment
There was a problem hiding this comment.
Looks good to me, and adding test and build targets is to me close enough for a single PR. Especially since it simplifies it a bit.
Agreed. I'll merge this now... |
2 participants
For the not so recently made available ARM64 runners in GHA, see: