Skip to content

Update deprecated range usage #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonmj merged 1 commit into from
Aug 4, 2025
Merged

Update deprecated range usage #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 10 additions & 16 deletions lib/plox/graph_scale.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,24 +15,18 @@ defmodule Plox.GraphScale do
def values(%__MODULE__{scale: scale}, opts \\ %{}), do: Scale.values(scale, opts)

def to_graph_x(%__MODULE__{scale: scale, dimensions: dimensions}, value) do
Scale.convert_to_range(
scale,
value,
(dimensions.margin.left +
dimensions.padding.left)..(dimensions.width -
dimensions.margin.right -
dimensions.padding.right)
)
first = dimensions.margin.left + dimensions.padding.left
last = dimensions.width - dimensions.margin.right - dimensions.padding.right
step = if first < last, do: 1, else: -1

Scale.convert_to_range(scale, value, first..last//step)
end

def to_graph_y(%__MODULE__{scale: scale, dimensions: dimensions}, value) do
Scale.convert_to_range(
scale,
value,
(dimensions.height -
dimensions.margin.bottom -
dimensions.padding.bottom)..(dimensions.margin.top +
dimensions.padding.top)
)
first = dimensions.height - dimensions.margin.bottom - dimensions.padding.bottom
last = dimensions.margin.top + dimensions.padding.top
step = if first < last, do: 1, else: -1

Scale.convert_to_range(scale, value, first..last//step)
end
end
2 changes: 1 addition & 1 deletion mix.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
defmodule Plox.MixProject do
use Mix.Project

@version "0.2.0"
@version "0.2.1"
@source_url "https://github.com/gridpoint-com/plox"

def project do
Expand Down