remove bad shellcheck tests and indicate which are error tests#15
Open
forivall wants to merge 1 commit intogrncdr:masterfrom
Open
remove bad shellcheck tests and indicate which are error tests#15forivall wants to merge 1 commit intogrncdr:masterfrom
forivall wants to merge 1 commit intogrncdr:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the shellcheck tests were code that shellcheck could parse, but were invalid shell (so that shellcheck could catch incorrect code specifically). This removes completely incorrect code, hotes which are ksh specific, corrects one mostly-correct example, and notes which should generate errors.