Finished file hierarchy implementation#120
Open
nipunramk wants to merge 1 commit intoground-context:masterfrom
Open
Finished file hierarchy implementation#120nipunramk wants to merge 1 commit intoground-context:masterfrom
nipunramk wants to merge 1 commit intoground-context:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
============================================
- Coverage 63.03% 58.57% -4.47%
Complexity 271 271
============================================
Files 66 70 +4
Lines 1339 1441 +102
Branches 136 149 +13
============================================
Hits 844 844
- Misses 466 568 +102
Partials 29 29
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One comment -- currently the file hierarchy is set so that it's by default global (cwd is "root"). We can change the cwd through the FileController.