Add a tool to parse metrics output and extract URLs within ranges by page view count#5
Add a tool to parse metrics output and extract URLs within ranges by page view count#5
Conversation
krollins-mdb
left a comment
There was a problem hiding this comment.
LGTM! Just a minor comment.
| } | ||
| } | ||
|
|
||
| func run() error { |
There was a problem hiding this comment.
Does it make sense to print a success message when a run completes without an error?
There was a problem hiding this comment.
I had it omit a success message since I thought we might use it in a pipeline - i.e. create this output and then use the output as the input in a next step. But if you'd prefer a success message, it's easy to add one!
There was a problem hiding this comment.
Nah, I wasn't totally sure if this was going to end up in a pipeline, but thought it might. A success message may be confusing in that case, so let's keep it out. Thanks for entertaining the thought.
krollins-mdb
left a comment
There was a problem hiding this comment.
Nice improvements with config file. I love config files. 😆
We have some internal tooling that outputs metrics with a specific format, similar to:
This tool can take the csv input and provide an output csv that:
This lets us get "top 50" or "top 250", or later, when we're ready, "250-300" or whatever that looks like.
I'll use the output with the Audit CLI to extract additional info to help us scope work related to these pages.
The tool creates an output csv with no headers like: