add a weekly limit #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so allow the kid to have more time by providing a file they can add to /tmp to provide a reset and more time. Z
Kids are using the computer as TV and video application blocks screen notifications - add sounds.
Make the code better readable and mark local variables. Also fix "min" and "allowed" in go_check() - these were unset local variables.
Add indentation everywhere and consistently
It downloads outdated files.
In between go_send() runs it needs to re-check if it should still logout.
We only want the hard coded path at the top of the file and also in /run
Another file that should be in /run (or /var/run) and code should also avoid repeated paths - use a global variable.
The current script was totally broken and kids could just wake up the system
We need to properly debianize to let people build debs on their own.
Updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I found your program and installed it for my 7 years old child. thanks for this great work that I couldn't find on the web.
My initial purpose was to limit the weekly usage, because 1h a day makes already 7h a week, but 1h is not enough to watch a 1,5h movie for example.
So it would be great to limit also the weekly max usage.
I don't know if you still maintain this, or if you are interested to do so; I could give it a go but I am not a programmer so it will probably take me 2-3 months to get it to work, while you knowing it well already can maybe do it quite simply.
The way I was thinking to do it is:
in the schedule, last line is weekdays, weekends, and add to that weekly_total.
in the time folder, have the user-daily.ttl and create a user-weekly.ttl
in the kidtimer program, add a test for the weekly limit, and reset it on sunday at midnight.
Please let me know if you could do it, otherwise, I will give it a go and send you my update when it's done if I manage to get it to work.
Thanks
Nicolas PIOT