Conversation
rvbnsk
requested review from
Littlenightingale,
arkadiusz-papaj,
filip6464 and
kamdz01
filip6464
approved these changes
Feb 19, 2023
|
|
||
| enum class Logger { Debug, Flight }; | ||
|
|
||
| enum class Modes { Idle, Measurements, Experiment, Uplink }; |
There was a problem hiding this comment.
Czym różni się Measurements od Experiment? Chyba czuje, różnice, ale czy to oznacza, że gdy odpalimy eksperyment to nie wykonujemy pomiarów z samego obc? (w sensie, czy mode Measurements pokrywa się jakoś z Experiment zadaniami).
Ogólnie to szczegół, przy takiej implementacji chyba łatwo będzie zedytować te stany/zdefiniować nowe. O to chodziło.
* changed I2C ports from defaults to custom * changed buzzer pin * added functions to main loop * changed buzzer pin to LED_BUILTIN --------- Co-authored-by: Kamil Dziedzic <kamdz01@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.