Added an option for change the guild vault rows#183
Open
rudde0 wants to merge 2 commits intoguilds-plugin:masterfrom
Open
Added an option for change the guild vault rows#183rudde0 wants to merge 2 commits intoguilds-plugin:masterfrom
rudde0 wants to merge 2 commits intoguilds-plugin:masterfrom
Conversation
Added option for change the guild vault rows
Added an option for change the guild vault rows.
Member
Member
|
How do you plan to handle the vault data in general? Have you tested creating a vault, filling it all the way up, and then changing the rows? Seems like it would delete the excess stuff. |
Contributor
Author
|
I think we can't do anything for that. |
Member
|
Well if that's the case, then it's probably best not to make this change as lots of people will lose items. |
Contributor
Author
|
We can add a warning for that idk this option is important for survival servers in my opinion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.