fix: correct boolean logic in zero_rank_print that prevented all output#436
Open
Mr-Neutr0n wants to merge 1 commit intoguoyww:mainfrom
Open
fix: correct boolean logic in zero_rank_print that prevented all output#436Mr-Neutr0n wants to merge 1 commit intoguoyww:mainfrom
Mr-Neutr0n wants to merge 1 commit intoguoyww:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
zero_rank_printfunction inanimatediff/utils/util.pycontains a boolean logic error that causes it to never print anything, regardless of the distributed process state.The Bug
The current condition is:
This follows the pattern
(NOT A) AND (A AND B), which is a logical contradiction — it requiresdist.is_initialized()to be bothFalseandTruesimultaneously. The condition evaluates toFalsefor every possible input, so the print statement is dead code.The Fix
Change the
andbetween the two clauses toor:This correctly implements the intended behavior:
This is the standard pattern used across PyTorch distributed training codebases for rank-guarded logging.