Skip to content

TRCLI-215: Non-matching cases with --plan-id crashes with error #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
acuanico-tr-galt wants to merge 1 commit into
base: release/1.13.1
Choose a base branch
from
Open

TRCLI-215: Non-matching cases with --plan-id crashes with error #389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions trcli/api/run_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,21 @@ def add_run(
include_all=include_all,
refs=refs,
)

# Validate that we have test cases to include in the run
# Empty runs are not allowed unless include_all is True
if not include_all and (not add_run_data.get("case_ids") or len(add_run_data["case_ids"]) == 0):
error_msg = (
"Cannot create test run: No test cases were matched.\n"
" - For parse_junit: Ensure tests have automation_id/test ids that matches existing cases in TestRail\n"
" - For parse_cucumber: Ensure features have names or @C test id tag matching the existing BDD cases"
)
return None, error_msg

if not plan_id:
response = self.client.send_post(f"add_run/{project_id}", add_run_data)
if response.error_message:
return None, response.error_message
run_id = response.response_text.get("id")
else:
if config_ids:
Expand All @@ -102,6 +115,8 @@ def add_run(
else:
entry_data = add_run_data
response = self.client.send_post(f"add_plan_entry/{plan_id}", entry_data)
if response.error_message:
return None, response.error_message
run_id = response.response_text["runs"][0]["id"]
return run_id, response.error_message

Expand Down