refactor: Add comprehensive type hints across all modules#10
Merged
haugoug merged 1 commit intogvsoc:mainfrom Mar 9, 2026
Merged
refactor: Add comprehensive type hints across all modules#10haugoug merged 1 commit intogvsoc:mainfrom
haugoug merged 1 commit intogvsoc:mainfrom
Conversation
Added type annotations to all function signatures (parameters and return types) across all 9 source files: - testsuite.py: Abstract base classes, Shell/Call/Checker commands - targets.py: Target class methods - reporting.py: table_dump_row with rich.Table param - config.py: ConfigLoader methods - stats.py: TestRunStats, TestStats, TestsetStats - tests.py: TestRun, TestCommon, TestImpl and all specialized test types - testset_impl.py: TestsetImpl methods - runner.py: Runner (~20 typed constructor params), Worker - __init__.py: future annotations import Uses from __future__ import annotations for forward references. No logic changes — only type annotations added. 122 tests passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds type annotations to every function signature across all 9 source files. No logic changes.
Files annotated
testsuite.pytargets.pyreporting.pytable_dump_row()withrich.Tableparam typeconfig.pystats.pytests.pytestset_impl.pyrunner.py__init__.pyfrom __future__ import annotationsUses
from __future__ import annotationsfor forward references andtypingmodule types (Optional,Callable,TextIO, etc.).122 tests passing.