fix: Resolve all pyright type-checking errors (0 errors)#11
Merged
haugoug merged 2 commits intogvsoc:mainfrom Mar 10, 2026
Merged
fix: Resolve all pyright type-checking errors (0 errors)#11haugoug merged 2 commits intogvsoc:mainfrom
haugoug merged 2 commits intogvsoc:mainfrom
Conversation
Fixed 30 pyright errors across 6 files: - __main__.py: None guards for runner in exception/no-fail paths - runner.py: explicit import importlib.util, None check on get_full_name(), fallback for psutil.cpu_count(), asserts for spec/loader - reporting.py: table_dump_row accepts int | float for numeric params - tests.py: timer init before conditional, None fallbacks on get_full_name(), assert proc.stdout, skip_message declared in __init__ - testsuite.py: get_target() returns Target | None, param name alignment - testset_impl.py: fixed __get_targets() variable shadowing, flags typed as str | None to match base class 122 tests passing. pyright: 0 errors, 0 warnings.
Reformatted only lines that exceeded 100 chars (59 lines across 7 files). Lines already within the limit are untouched. 122 tests passing. Pyright: 0 errors.
germainh512
force-pushed
the
pyright-fixes
branch
from
b75e9c3 to
40c6221
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes all 30 pyright errors. Clean bill of health: 0 errors, 0 warnings.
Changes
__main__.pyrunnerin exception handler and--no-failcheckrunner.pyimport importlib.util, None check onget_full_name(), fallback forpsutil.cpu_count(), asserts for spec/loaderreporting.pytable_dump_rownumeric params accept `inttests.pytimerinit before conditional, None fallbacks onget_full_name(),assert proc.stdout,skip_messagedeclared in__init__testsuite.pyget_target()returns `Targettestset_impl.py__get_targets(), `flags: str122 tests passing.