feat: Replace eval with ${VAR} env expansion in Target#13
Merged
haugoug merged 1 commit intogvsoc:mainfrom Mar 10, 2026
Merged
Conversation
sourceme and envvars values now use ${VAR} syntax for environment
variable expansion instead of Python eval()/ast.literal_eval().
Before (Python expression, broken by literal_eval):
"sourceme": "os.path.join(os.environ.get(\"SDK\"), \"setup.sh\")"
After (simple template):
"sourceme": "${SDK}/setup.sh"
- ${VAR} expands to os.environ.get("VAR", "")
- Missing variables expand to empty string
- Multiple ${VAR} refs in one value are supported
- No code execution at all — pure string substitution
- No backward compat shim (existing configs need updating)
126 tests passing (20 target tests, 6 new).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Change
sourcemeandenvvarsvalues in target configs now use${VAR}syntax instead of Python expressions.Before
{ "sourceme": "os.path.join(os.environ.get(\"PULP_SDK_HOME\"), \"configs\", \"pulp-open.sh\")", "envvars": { "TOOLCHAIN": "os.environ.get(\"PULP_NN_GCC_TOOLCHAIN\")" } }After
{ "sourceme": "${PULP_SDK_HOME}/configs/pulp-open.sh", "envvars": { "TOOLCHAIN": "${PULP_NN_GCC_TOOLCHAIN}" } }How it works
${VAR}→os.environ.get("VAR", "")${VAR}refs per value supportedNo backward compatibility
Existing configs using
os.path.join/os.environ.getexpressions need to be updated to the new${VAR}syntax.126 tests passing (6 new target tests added).