refactor: Split runner.py into focused modules#6
Merged
haugoug merged 1 commit intogvsoc:mainfrom Mar 9, 2026
Merged
Conversation
Split the 1130-line monolithic runner.py into 5 focused modules:
- targets.py — Target class (config, envvars, properties, sourceme)
- tests.py — TestRun, TestCommon, TestImpl, MakeTestImpl,
GvrunTestImpl, SdkTestImpl, NetlistPowerSdkTestImpl
- stats.py — TestRunStats, TestStats, TestsetStats
- reporting.py — bcolors, table_dump_row
- testset_impl.py — TestsetImpl
runner.py now contains only Runner and Worker (~300 lines), with
re-exports for backward compatibility (existing imports from runner
still work).
Pure refactor — no behavior changes. 116 tests pass, real testsuite
(gvsoc-sdk examples) verified: 12/12.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split the 1130-line monolithic
runner.pyinto 5 focused modules. Pure refactor — no behavior changes.New module structure
Backward compatibility
runner.pyre-exports all moved classes, so existing code that doesfrom gvtest.runner import Targetetc. continues to work unchanged.Verification