A simpler, smaller and faster implementation of String.replace#10193
A simpler, smaller and faster implementation of String.replace#10193vjay82 wants to merge 2 commits intogwtproject:mainfrom
Conversation
|
Something funny is happening in the tests for this change, I'm suspicious that this actually changes behavior in some fundamental way: These suites don't usually take 20+ minutes to run. It doesn't seem to be a fluke, I re-ran them and they still timed out the build. I'm not sure why this doesn't impact other runs - we're triggering the timeout for "this test isn't doing anything, kill it" There is an error from htmlunit, it looks like our htmlunit build is too old to reliably use replaceAll: replaceAll is relatively new, standard as of 2020 https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replaceAll#browser_compatibility - our release of htmlunit is missing this, so we might need to back-burner this until we're ready for an htmlunit version bump (like #10113). In theory, we could do that while staying on ant with #10115, or wait until we're away from ant, and then just bump to a new release. |
|
Minimal version of HtmlUnit for this is 3.11.0 HtmlUnit/htmlunit-rhino-fork@3f5f6cc |
As discussed in #10178