Compute total size of samples correctly#10263
Merged
niloc132 merged 2 commits intogwtproject:mainfrom Jan 31, 2026
Merged
Conversation
niloc132
previously approved these changes
Jan 31, 2026
Member
niloc132
left a comment
niloc132
left a comment
There was a problem hiding this comment.
Thank you, that's embarrassing. I had it right the first iteration of the samples update, then I kept making changes and didn't go back to check...
niloc132
reviewed
Jan 31, 2026
Co-authored-by: Colin Alworth <colin@vertispan.com>
niloc132
added
the
ready
niloc132
approved these changes
Jan 31, 2026
Member
|
https://github.com/gwtproject/gwt/actions/runs/21551778682/job/62101622026?pr=10263 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the size of compiled samples reported during a build.
Except for
helloall samples have multiple modules, sotargetis not always in the top level folder. Also included deferredjs/ for split point content.