interceptors/urllib3: return version and version_string in response#176
Merged
sarayourfriend merged 1 commit intoh2non:masterfrom Mar 11, 2026
Merged
interceptors/urllib3: return version and version_string in response#176sarayourfriend merged 1 commit intoh2non:masterfrom
sarayourfriend merged 1 commit intoh2non:masterfrom
Conversation
>>> import urllib3
>>> resp = urllib3.request("GET", "https://httpbin.org/robots.txt")
>>> resp.version
11
>>> resp.version_string
'HTTP/1.1'
xrmx
commented
Mar 9, 2026
| reason=http_reasons.get(res._status), | ||
| original_response=FakeResponse(method, headers), | ||
| version=11, | ||
| version_string="HTTP/1.1", |
Contributor
Author
There was a problem hiding this comment.
This is urllib3>=2 but I don't think it would be a problem for people still mocking urllib3<2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add missing version and a version_string that are available in urllib3 response:
PR Checklist