Skip to content

Conversation

@sezanzeb
Copy link
Collaborator

➜  tilt git:(chore) yarn audit --groups dependencies                        

yarn audit v1.22.22
0 vulnerabilities found - Packages audited: 532
Done in 1.12s.
➜  tilt git:(chore) yarn backend::test                           
yarn run v1.22.22
$ cd backend/ && jest --coverage --runInBand
 PASS  test/services/user-service.spec.ts
 PASS  test/services/application-service.spec.ts
 PASS  test/services/http-service.spec.ts
 PASS  test/services/tilt-service.spec.ts
 PASS  test/controllers/users-controller.spec.ts
 PASS  test/services/settings-service.spec.ts
 PASS  test/middlewares/error-handler-middleware.spec.ts
 PASS  test/services/question-service.spec.ts
 PASS  test/services/logger-service.spec.ts
 PASS  test/services/token-service.spec.ts
 PASS  test/services/haveibeenpwned-service.spec.ts
 PASS  test/controllers/settings-controller.spec.ts
 PASS  test/services/config-service.spec.ts
 PASS  test/tilt.spec.ts
...
Test Suites: 14 passed, 14 total
Tests:       82 passed, 82 total
Snapshots:   0 total
Time:        6.222 s, estimated 74 s
Ran all test suites.
Done in 6.63s.

image

I guess I'll insert the smtp configuration of one of my email services, gmail or something, and do some manual testing next.

@sezanzeb
Copy link
Collaborator Author

Frontend tests are broken. Current error is

➜  tilt git:(chore) ✗ yarn frontend::test                                        
yarn run v1.22.22
$ cd frontend/ && jest --coverage --runInBand
Test environment found at "/mnt/data/Code/tilt/node_modules/jest-environment-jsdom/build/index.js" does not export a "getVmContext" method, which is mandatory from Jest 27. This method is a replacement for "runScript".

 RUNS  test/components/button.spec.tsx
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

However, since enzyme is abandoned and there are hardly any frontend tests, I guess I'd rather recommend to rewrite them from scratch. I don't know what people use to test react, not my area of expertise.

@sezanzeb
Copy link
Collaborator Author

sezanzeb commented Feb 28, 2025

@sezanzeb
Copy link
Collaborator Author

sezanzeb commented Mar 1, 2025

before:

image

after:

image

@sezanzeb
Copy link
Collaborator Author

sezanzeb commented Mar 1, 2025

@marc101101 ProfileFormApply and ConfirmationFormApply lead nowhere, am I missing something?

Relevant commit: 50797c5

@sezanzeb
Copy link
Collaborator Author

sezanzeb commented Mar 1, 2025

@marc101101 ProfileFormApply and ConfirmationFormApply lead nowhere, am I missing something?

Relevant commit: 50797c5

ProfileFormApply and ConfirmationFormApply missing in: https://github.com/hackaburg/tilt/blob/main/frontend/src/components/routers/authenticated-router.tsx

@marc101101 marc101101 marked this pull request as ready for review March 31, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants