wip: MintRallyViewer.sol like ERC1155 without write functions#524
Open
yawn-c111 wants to merge 3 commits intohackdays-io:stagingfrom
Open
wip: MintRallyViewer.sol like ERC1155 without write functions#524yawn-c111 wants to merge 3 commits intohackdays-io:stagingfrom
yawn-c111 wants to merge 3 commits intohackdays-io:stagingfrom
Conversation
|
@yawn-c111 is attempting to deploy a commit to the Code for Japan Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
|
いいですね！ |
Collaborator
Author
|
@yu23ki14 現状はeventIdにしてあります！ ただ、書いてる途中でgroupIdにするのもありだなと感じてまして、用途によっては変更または併用（片方の関数名は独自命名）もいいかも…と思ってました！ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
編集中です！
MintRallyのNFT(MintNFT.sol)のview関数を使って、eventIdをtokenIdに見立ててERC1155かのように表示できるsolファイルを作成し、サンプルとして私個人の秘密鍵でMintRallyの全コントラクトとともにテストネットにデプロイしました！（stagingを汚さないために）
MintNFT サンプル：
0x225B131690c2648EE58E7684e613C07D01A1B946EventManager サンプル：
0x71BAfD0812b483054b7e0c66dB428eB4AA54E13CMintRallyViewer サンプル：
0x283024996Bab0364A5Daa7a81A87eAF645a70eD6私のdevアドレスのOpenseaページ：
https://testnets.opensea.io/ja/0xc5952da2d393d3421D56bd5FBCac1F8a3df40567
MintNFT サンプルのOpenseaページ：
https://testnets.opensea.io/ja/collection/mintrally-15
現状では、ERC1155のViewerをかませても、同じNFTがERC721とERC1155で2重に表示される現象は起きていません。（少し様子を見た方がいいかも？）
※ 私の手元では hardhat.config.ts の solidity version を
"0.8.20"に設定してありますが、こちら影響が大きい気がしたので、プッシュはしてません。