This repository was archived by the owner on May 19, 2023. It is now read-only.
GitHub rudradave1/feature/settingsui#46
Closed
rudradave1 wants to merge 4 commits intobranch_loveleenfrom
Closed
Conversation
* Adding CODEOWNERS files. Still needed to add the Default reviewer for the two teams. * Update CODEOWNERS * fix the validation issues on GitHub. * updated owners for all the branches. * updated the Wrong branch combinations.
Added the PR Templates + .gitignore
…ote-x into github-rudradave1/feature/settingsui
3 tasks
rudradave1
requested review from
loveleenkaurnancy
and removed request for
hadiyarajesh
hadiyarajesh
suggested changes
Sep 13, 2022
Owner
hadiyarajesh
left a comment
hadiyarajesh
left a comment
There was a problem hiding this comment.
Kindly rebase your branch with @loveleenkaurnancy branch and then PR
Owner
|
Please change your upstream branch to Loveleen's branch. you don't need to merge to |
Owner
|
@rudradave1 can you rebase your base branch with geet and create a PR for the same? |
Owner
|
I think we don't need this PR as we already have Am I correct? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added settings screen UI