Conversation
this applies all patches from openbsd ports. the differences are mostly imsg api fixes and type declaration changes.
|
i'm not sure why @gonzalo- didn't send these, maybe they can chime in. |
nbriggs
left a comment
nbriggs
left a comment
There was a problem hiding this comment.
At first glance, these (imsg interface changes) look as though they'll break the FreeBSD port. FreeBSD has its own collection of patches which used to be applied against the 0.7 release.
i'm wholly unfamiliar with freebsd, as i only use openbsd, but if i understand correctly, mdnsd is designed for and intended to be run on openbsd. freebsd may need to adjust their patches. |
There was a problem hiding this comment.
FreeBSD ports had to make this change too.
There was a problem hiding this comment.
FreeBSD ports had to make this change too.
There was a problem hiding this comment.
FreeBSD ports had to make this change too.
|
So I'm fine with img changes, I have to go over them more carefully, but the control struct redefinition I can't make sense of it, neither the typedefs. Can you churn down this to just the imsg changes? Or am I missing something else? |
he be slacking, doesn't even send me alfajores anymore! |
ok, fixed up the type changes in my second commit. the 'missing piece' is that these are fixes for building with -fno-common which became the default in gcc some time ago. see openbsd/ports@dbed198... |
Cool, leme get a VM and try this, might take me sometime, but I'll try to do it this weekend, then I can see what works best. |
ping. lightly retested on -current, mdnsctl lookup/browse are working as well as |
Great! I'll merge something similar, I just want to refactor the typedefs and whatnot. |
3 participants
this applies all patches from openbsd ports. the differences are mostly imsg api fixes and type declaration changes.