Open
Conversation
weihanglo
reviewed
Apr 30, 2020
| @@ -0,0 +1,42 @@ | |||
| #!/usr/bin/env bash | |||
Contributor
There was a problem hiding this comment.
想問 scripts/bump-version.sh 會是誰在用？更改 chart 的人？
Contributor
Author
There was a problem hiding this comment.
yap，之後看能不能透過 CD 自動升（但要配合一套完整的 git branching 流程
scripts/bump-version.sh
Outdated
| sed -i"" "s/^ version: \"$CURRENT_VERSION\"$/ version: \"$NEW_VERSION\"/" $ROOT_PATH/starter/Chart.yaml | ||
|
|
||
| echo "Updating README.md..." | ||
| sed -i"" "/^### Adding Dependency$/,/^### Using Starter$/s;version: $CURRENT_VERSION;version: $NEW_VERSION;" $ROOT_PATH/README.md |
Contributor
There was a problem hiding this comment.
我的 macbook 原生的 sed -i"" 直接連著會 invalid command code，要改成 sed -i ""
附上版本資訊 /usr/bin/sed BSD May 10, 2005
Contributor
Author
There was a problem hiding this comment.
換成 BSD sed 的寫法了 🙇
scripts/bump-version.sh
Outdated
|
|
||
| UPDATED_PART_VAR=$(echo $UPDATED_PART | tr '[:lower:]' '[:upper:]')_VERSION | ||
| eval $UPDATED_PART_VAR'=$(($'$UPDATED_PART_VAR' + 1))' | ||
| NEW_VERSION=$MAJOR_VERSION.$MINOR_VERSION.$PATCH_VERSION |
Contributor
There was a problem hiding this comment.
這邊不太合理？bump 大阪好時小版號應該要歸零吧？
|
|
||
| echo "Creating chart..." | ||
| mkdir "$CHART_NAME" | ||
| curl --proto '=https' --tlsv1.2 -sSf https://codeload.github.com/hahow/common-chart/tar.gz/master | \ |
Contributor
There was a problem hiding this comment.
codeload.github.com 是最後 redirect 到的網址沒錯吧？我不確定他不是不是 public facing 的網址，以後可能會被改掉？
Contributor
Author
There was a problem hiding this comment.
確實有可能以後會改，但目前看來這個網址是滿普遍的用法，等被改掉再換？
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.