Open
Conversation
sertansenturk
requested changes
Jan 27, 2019
Collaborator
sertansenturk
left a comment
sertansenturk
left a comment
There was a problem hiding this comment.
- Please work on these changes after we close #11 -
As described in #17 (review), the environment file should only store the relevant packages, and it should be platform-agnostic.
Could you:
- Delete the
spec-file.txt(because otherwise it will conflict with 17 - Add only the relevant packages that you include
MockTraining.ipynb(nothing more, nothing less)
sertansenturk
requested changes
Jan 27, 2019
Collaborator
sertansenturk
left a comment
sertansenturk
left a comment
There was a problem hiding this comment.
According to PEP8 "modules (filenames) should have short, all-lowercase names, and they can contain underscores". Could you fix it -> mock_training.ipynb?
Collaborator
|
Note: I haven't checked the content of the notebook yet. I will do it after, the above issues are fixed. |
4 tasks
Owner
Author
|
I add this notebook into #37 I will delete this branch, if no one argue it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have created and trained LSTM baseline with small dataset. I used just hicaz--sarki datas from SymbTr. You can check original distribution of Koma53 values and generated distribution of it.