Conversation
…names instead of the style prop This allows a much smaller payload in SPA's and also reduces the size of hammer-time, but it also moves away from being a polyfill a little
pzuraq
reviewed
Oct 4, 2016
| document.documentElement.style[ "-ms-touch-action" ]; | ||
|
|
||
| // If there is native touch action bail the hammer has already dropped | ||
| if ( nativeTouchAction || !touchevents || !MO ) { |
|
Looks good other than the one bug, think this will work for class-based hammertime 😄 |
|
Regarding the questions:
|
Collaborator
I was going to auto-add something like this for ember-hammertime.
maybe just some presets for the 3 we support? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…names instead of the style prop
This allows a much smaller payload in SPA's and also reduces the size of hammer-time,
but it also moves away from being a polyfill a little
Questions
Should we abstract the core methods and make MO / Class an extension to coreAlready decided to do this