Bump jquery version to 'current' version for 2019#57
Open
wunderkind2k1 wants to merge 2 commits intohammerjs:masterfrom
Open
Bump jquery version to 'current' version for 2019#57wunderkind2k1 wants to merge 2 commits intohammerjs:masterfrom
wunderkind2k1 wants to merge 2 commits intohammerjs:masterfrom
Conversation
Author
|
@jtangelder are you still working on this? It has been rather quiet around hammer.js and its suprojects lately. |
|
@wunderkind2k1 i see this has not been updated for a long time, do you perhaps have a more up to date forked version ? |
Author
|
@Ig0r-M I am sorry but I ain't have got a forked version. I am not working on that project which uses hammerjs anymore. As far as I remember we only required hammerjs as a transitive dependency during selenium (or puppeteer) tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
I noticed that hammer.js has a transitive dependency to jquery 2.2.1 through jquery.hammer.js.
This should fix it. I am not sure how we can check against regressions. Any idea?
It this PR works and jquery.hammer.js is published to npm and hammer.js updates its version of jquery.hammer.js this issue: hammerjs/hammer.js#1138 can be solved I guess.
Hope I am not badly wrong.