Fix tests for citgm

[devinivy]

There are a few issues to fix for failures in citgm:

1. Tests that rely on lsof on node v14. @cjihrig previously made a fix for this in allow tests using lsof to pass on ENOENT #3744, but on node v14 the way to detect this error changed. lookup: add hapi nodejs/citgm#436 (comment)
2. Some flaky/failing tests on macos and AIX. As far as I can tell the issue here is flakiness due to timing-dependent tests and slow IO in CI. I attempted to make these tests less timing-dependent and to better cleanup after themselves, which allows them to be retryable. I would love some review of these changes, as they are some of the more complex tests in the hapi test suite. lookup: add hapi nodejs/citgm#436 (comment)

CC @AdriVanHoudt I know in nodejs/citgm#436 you were able to reproduce the macos issues. If you have time and would be open to trying out these changes it would be very much appreciated.

[devinivy]

In some (flaky) cases this error was being triggered late and causing the next test to fail.

[kanongil]

Yeah, lab does not bind the expect to a specific test, so it can only assume that errors are caused by the current test.

[kanongil]

Mostly nits, but the "handles race condition between equal client and server timeouts" rewrite seems like it is not doing the same thing.

[kanongil]

Yeah, lab does not bind the expect to a specific test, so it can only assume that errors are caused by the current test.

[devinivy]

@kanongil I appreciate the review, and I've incorporated your feedback.

[Nargonath]

LGTM

[kanongil]

Still a few nits.

[devinivy]

I appreciate all the careful review 👍

[AdriVanHoudt]

For what it's worth I still see these on master

Failed tests:

  393) Request active() exits handler early when request is no longer active:

      Timed out (5000ms) - Request active() exits handler early when request is no longer active


  417) Request _postCycle() skips onPreResponse when validation terminates request:

      Timed out (5000ms) - Request _postCycle() skips onPreResponse when validation terminates request

I don't have the bandwidth to dive into this atm but if I can help by running some tests or something let me know. (for quicker response dm me on slack)