Skip to content

Set Message.channel in PcanBus.recv #1969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zariiii9003 merged 1 commit into from
Aug 5, 2025
Merged

Set Message.channel in PcanBus.recv #1969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions can/interfaces/pcan/pcan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,6 +590,7 @@ def _recv_internal(
)

rx_msg = Message(
channel=self.channel_info,
timestamp=timestamp,
arbitration_id=pcan_msg.ID,
is_extended_id=is_extended_id,
Expand Down
1 change: 1 addition & 0 deletions doc/changelog.d/1969.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
PcanBus: Set `Message.channel` attribute in `PcanBus.recv()`.
2 changes: 2 additions & 0 deletions test/test_pcan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ def test_recv(self):
self.assertEqual(recv_msg.is_fd, False)
self.assertSequenceEqual(recv_msg.data, msg.DATA)
self.assertEqual(recv_msg.timestamp, 0)
self.assertEqual(recv_msg.channel, "PCAN_USBBUS1")

def test_recv_fd(self):
data = (ctypes.c_ubyte * 64)(*[x for x in range(64)])
Expand All @@ -255,6 +256,7 @@ def test_recv_fd(self):
self.assertEqual(recv_msg.is_fd, True)
self.assertSequenceEqual(recv_msg.data, msg.DATA)
self.assertEqual(recv_msg.timestamp, 0)
self.assertEqual(recv_msg.channel, "PCAN_USBBUS1")

@pytest.mark.timeout(3.0)
@patch("select.select", return_value=([], [], []))
Expand Down
Loading