Skip to content

refactor(protobuf): update protobuf imports #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antegral wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(protobuf): update protobuf imports #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ module github.com/hashicorp/go-plugin
go 1.24

require (
github.com/golang/protobuf v1.5.3
github.com/hashicorp/go-hclog v0.14.1
github.com/hashicorp/yamux v0.1.1
github.com/jhump/protoreflect v1.15.1
Expand All @@ -15,6 +14,7 @@ require (
require (
github.com/bufbuild/protocompile v0.4.0 // indirect
github.com/fatih/color v1.7.0 // indirect
github.com/golang/protobuf v1.5.3 // indirect
Copy link

@sonamtenzin2 sonamtenzin2 Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this manually added or was it added as a part of go mod tidy ?

Copy link

@kaovilai kaovilai Jan 14, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See diff, removed from line 6, moved to indirect. It meant it's no longer being directly used, coinciding with require line removals in below .go files.

I wouldn't concern with this change.

Copy link

@sonamtenzin2 sonamtenzin2 Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is not being used directly. But running go mod tidy will check in case it can be removed as indirect dependency as well

Ran it locally, seems to fine

github.com/mattn/go-colorable v0.1.4 // indirect
github.com/mattn/go-isatty v0.0.17 // indirect
github.com/stretchr/testify v1.8.3 // indirect
Expand Down
2 changes: 1 addition & 1 deletion grpc_stdio.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ import (
"context"
"io"

empty "github.com/golang/protobuf/ptypes/empty"
hclog "github.com/hashicorp/go-hclog"
"github.com/hashicorp/go-plugin/internal/plugin"
"google.golang.org/grpc"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/status"
empty "google.golang.org/protobuf/types/known/emptypb"
)

// grpcStdioBuffer is the buffer size we try to fill when sending a chunk of
Expand Down
2 changes: 1 addition & 1 deletion plugin_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ import (
"testing"
"time"

"github.com/golang/protobuf/ptypes/empty"
"github.com/hashicorp/go-hclog"
grpctest "github.com/hashicorp/go-plugin/test/grpc"
"google.golang.org/grpc"
empty "google.golang.org/protobuf/types/known/emptypb"
)

// Test that NetRPCUnsupportedPlugin implements the correct interfaces.
Expand Down