Skip to content

fix: use openstack as hcp metadata provider name #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mogrogan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use openstack as hcp metadata provider name #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions builder/openstack/artifact.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ func (a *Artifact) State(name string) any {
log.Printf("[DEBUG] error encountered when creating a registry image %v", err)
return nil
}
img.ProviderName = "openstack"
return img

}
Expand Down
2 changes: 1 addition & 1 deletion builder/openstack/artifact_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ func TestArtifactState_StateData(t *testing.T) {
func TestArtifactState_hcpPackerRegistryMetadata(t *testing.T) {
artifact := &Artifact{
ImageId: "foo",
BuilderIdValue: "openstack",
BuilderIdValue: "mitchellh.openstack",
Copy link
Contributor

@anurag5sh anurag5sh Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, is this change made to avoid breaking this particular test?

Copy link
Contributor Author

@mogrogan mogrogan Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is to make sure that it doesn't prepend the mitchellh when fetching the ProviderName (problem with UI openstack icon rendering)

SourceImage: "bar",
Region: "mordor-7",
}
Expand Down
Loading