add new hw settings and config options#165
Conversation
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
|
@anurag5sh @devashish-patel @nywilken Can I get a review of this PR? Thanks |
|
@tanmay-hc can I get a review of this PR please? |
| // Set the graphics controller, defaulting to "vboxsvga" unless overridden by "vmDefaults" or config. | ||
| if config.GfxController == "" { | ||
| config.GfxController = "vboxvga" | ||
| config.GfxController = "vboxsvga" |
There was a problem hiding this comment.
Is there a reason why this is being changed from vboxvga to vboxsvga. I have observed that for linux guests the vboxvga works correctly in my host as compared to vboxsvga.
There was a problem hiding this comment.
In settings for a Linux vm it will show an orange triangle warning in ui and states invalid settings detected and recommends switching to vboxsvga. New box setup via wizard also defaults to vboxsvga. So this aligns to what vbox recommends.
There was a problem hiding this comment.
I just checked it and it looks like for linux it actually recommends VMSVGA and for windows it recommends VboxSVGA.
There was a problem hiding this comment.
If it helps to get this reviewed and merged, I'd be happy to change it back.
2 participants
Description
Updating plugin for latest virtualbox hardware options for both arm and intel based hosts
Resolved Issues
If your PR resolves any open issue(s), please indicate them like this so they will be closed when your PR is merged:
Closes #137
Supersedes #138
Supersedes #146
Supersedes #148
Rollback Plan
If a change needs to be reverted, we will roll out an update to the code within 7 days.
Changes to Security Controls
none