Skip to content

[Snyk] Security upgrade sinon from 4.5.0 to 16.1.2 #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hashim21223445 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Security upgrade sinon from 4.5.0 to 16.1.2 #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion samples/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"ava": "^5.3.0",
"nyc": "^15.0.0",
"proxyquire": "1.8.0",
"sinon": "4.5.0",
"sinon": "16.1.2",
Copy link

@gemini-code-assist gemini-code-assist bot Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This upgrade to sinon@16.1.2 introduces a critical breaking change related to the supported Node.js version.

  • Node.js Incompatibility: sinon@16.1.2 requires Node.js version 16 or higher, but your package.json's engines field specifies support for Node.js >=4.3.2. This will break the development and CI environments for anyone using an older, yet supposedly supported, Node.js version.

  • Vulnerability Fix: The security vulnerability (SNYK-JS-DIFF-14917201) is resolved in sinon versions 5.0.0 and newer. However, even sinon@5.x requires Node.js >= 6, meaning support for Node.js 4 must be dropped to fix this issue.

  • Recommendation: To minimize disruption from Sinon's own API breaking changes across so many major versions, I recommend a more conservative upgrade. Upgrading to a version like ^7.5.0 will fix the security vulnerability while requiring a smaller update to your minimum supported Node.js version (Node.js >= 6).

You will also need to update the engines.node field in package.json to ">=6.0.0" to reflect this new requirement.

Suggested change
"sinon": "16.1.2",
"sinon": "^7.5.0",

"uuid": "^3.1.0"
}
}
Loading