Reject unconstrained dependency = none|all|eq#11470
Draft
philderbeast wants to merge 25 commits intohaskell:masterfrom
Draft
Reject unconstrained dependency = none|all|eq#11470philderbeast wants to merge 25 commits intohaskell:masterfrom
none|all|eq#11470philderbeast wants to merge 25 commits intohaskell:masterfrom
Conversation
none|all|eq
0ddde8d to
4142036
Compare
8b84ba1 to
4027553
Compare
- Update test for == constraint check - Add OnlyConstrainedEq - Test --reject-unconstrained-dependencies=eq - Add haddocks for eq option - Remove pkgIsExplicit - One-line keepNonEmpty - Use pattern guard - Top level filterThisVersion - Name tests
a12abc2 to
c0117b5
Compare
4d58984 to
151bb3f
Compare
- Use onlyConstrainedAll in solver unit tests - Add unit tests for =eq and =none - Add whenNone, whenAll and whenEq - Enhance the failure message expectation
151bb3f to
ebf288a
Compare
7dd37ba to
3fb1ada
Compare
517e233 to
8edde84
Compare
8edde84 to
c5d436a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11468. Adds an
eqoption for--reject-unconstrained-dependencies. Extends the solving failure reason message to include=allor=eq.Manual QA
With this repository,
cabal freeze.Edit
cabal.project.freezecommenting out the line for theprettydependency.Now
cabal build cabal-install-solver --reject-unconstrained-dependencies=?will only build when ? is none.Edit
cabal.project.freezechanging the line for theprettydependency.Now
cabal build --reject-unconstrained-dependencies=?will build when ? isnone|allbut won't build when ? iseq.Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significantin the changelog file.