Skip to content

Fix parser warnings order#11479

Open
omarjatoi wants to merge 2 commits intohaskell:masterfrom
omarjatoi:11269-warnings-in-reverse
Open

Fix parser warnings order#11479
omarjatoi wants to merge 2 commits intohaskell:masterfrom
omarjatoi:11269-warnings-in-reverse

Conversation

@omarjatoi
Copy link

See #11269 for more information. This PR changes the parse results to append warnings so they're displayed in-order.


This PR modifies behaviour or interface

Include the following checklist in your PR:

Copy link
Collaborator

@geekosaur geekosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine aside from the missing field in the changelog.

@omarjatoi
Copy link
Author

Thanks! Let me get that fixed.

See haskell#11269 for more information. This PR changes the parse results to append warnings so they're displayed in-order.

Resolves: haskell#11269
@omarjatoi omarjatoi force-pushed the 11269-warnings-in-reverse branch from 7d06af6 to 65195c4 Compare February 7, 2026 19:45
@geekosaur
Copy link
Collaborator

I do wonder if just doing a reverse at the end would be better, but on the other hand if they have enough warnings for that to make a significant difference then they have bigger problems than warning collection. 😁

@omarjatoi
Copy link
Author

Yeah I thought of doing that at first, and figured it maybe made sense to just return the warnings in the correct order instead of having to reverse them. But I do not feel strongly, if that's preferred I'd be happy to make that change.

@geekosaur
Copy link
Collaborator

No, I don't think it's really necessary. The downside of xs ++ [x] is that it has to traverse xs, but again if they have that many warnings that this shows, they have bigger problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants