Skip to content

Fix 11473: Fixes the newline issue for hscolour help command#11481

Merged
mergify[bot] merged 1 commit intohaskell:masterfrom
adpad-13:hscolour-newline
Feb 13, 2026
Merged

Fix 11473: Fixes the newline issue for hscolour help command#11481
mergify[bot] merged 1 commit intohaskell:masterfrom
adpad-13:hscolour-newline

Conversation

@adpad-13
Copy link
Contributor

Description

This PR fixes a formatting issue where the hscolour command help output was missing a trailing newline character in its commandNotes section.

I tried it with many commands and found that only hscolour has the issue because of the missing '\n' character, so this should fix it.

Related Issue

Fixes #11473

Steps to Reproduce & Verify

To verify the missing newline in the current master branch:

  1. Run: cabal hscolour --help | tail -c 1 | od -An -tc
  2. Observation: The output is . , so no newline.

To verify the fix in this branch:

  1. Run: cabal run cabal-install -- hscolour --help | tail -c 1 | od -An -tc
  2. Observation: The output is \n.

Changes

  • Modified Cabal/src/Distribution/Simple/Setup/Hscolour.hs.
  • Added an explicit \n to the commandNotes string within the hscolourCommand definition.

@geekosaur geekosaur added attention: needs-review re: help-text Concerning option --help and hints given to the user labels Feb 10, 2026
@philderbeast
Copy link
Collaborator

With #11472 already merged, this will fix #11473.

Template B: This PR does not modify behaviour or interface

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@philderbeast philderbeast added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Feb 11, 2026
@mergify mergify bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days queued labels Feb 11, 2026
@mergify
Copy link
Contributor

mergify bot commented Feb 13, 2026

Merge Queue Status

Rule: default


This pull request spent 2 hours 5 minutes 35 seconds in the queue, including 1 hour 55 minutes 16 seconds running CI.

Required conditions to merge
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Validate post job
    • check-neutral = Validate post job
    • check-skipped = Validate post job
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

mergify bot added a commit that referenced this pull request Feb 13, 2026
@mergify mergify bot merged commit 78ab5e8 into haskell:master Feb 13, 2026
289 checks passed
@mergify mergify bot removed the queued label Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge re: help-text Concerning option --help and hints given to the user ready and waiting Mergify is waiting out the cooldown period

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Command help should end with newline

3 participants