Conversation
Member
Author
|
@dterei PR is ready. |
Building the testsuite broke with GHC 9.8 because containers started to depend on template-haskell which depends on pretty.
Member
Author
|
Ok, the build of the testsuite is only finally breaking with GHC 9.8, so I included the testsuite in CI for some older versions of GHC (9.6 for ci.yml, 9.0/2 for Haskell CI). |
dterei
approved these changes
Jul 28, 2025
Member
|
Thanks @andreasabel! Merged :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove trailing whitespace and turn tabs to spaces
Fix building testsuite (import conflict)
Make benchmarks build again (fix import conflicts)
Test and benchmarks can however not run in CI due to:
A hack to build it locally was to rename
prettyto something else in thepretty.cabalfile.(Maybe this hack could be institutionalized in the CI using a patch that is applied before the build.)