Skip to content

Comments

[FIX] Rename Network.setRequestInterceptionEnabled#1

Open
michalgritzbach wants to merge 3 commits intohassox:masterfrom
michalgritzbach:fix-network-requestinterception-call
Open

[FIX] Rename Network.setRequestInterceptionEnabled#1
michalgritzbach wants to merge 3 commits intohassox:masterfrom
michalgritzbach:fix-network-requestinterception-call

Conversation

@michalgritzbach
Copy link

@michalgritzbach michalgritzbach commented Mar 1, 2018

Rename Network.setRequestInterceptionEnabled --> Network.setRequestInterception in HPDF.Printer.

This is change from Chromium r511134, if i understood it correctly. Anyway, Network.setRequestInterceptionEnabled is no more and causes printing PDF to fail.

@michalgritzbach
Copy link
Author

Ok, I was a little bit too fast, turns out that setRequestInterception expects to receive an array, which I wasn't able to pull together. But omitting this call altogether makes the whole thing working as it was before. If I understand this correctly, omitting the urlPattern parameter means it is * by default and that means it's enabled. And that means that we don't have to call setRequestInterception at all. Do you know something about this whole thing?

@hassox
Copy link
Owner

hassox commented Mar 5, 2018

tbh I haven't looked at the latest docs from google until just now. These are all tip of tree docs so subject to change. Unfortunately just no enabling interception will mean that the authentication parts of hpdf will not work (I think). I've gotta get to work atm but will look asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants