[FIX] Rename Network.setRequestInterceptionEnabled#1
Open
michalgritzbach wants to merge 3 commits intohassox:masterfrom
Open
[FIX] Rename Network.setRequestInterceptionEnabled#1michalgritzbach wants to merge 3 commits intohassox:masterfrom
michalgritzbach wants to merge 3 commits intohassox:masterfrom
Conversation
…uestInterception in HPDF.Printer
Author
|
Ok, I was a little bit too fast, turns out that |
Owner
|
tbh I haven't looked at the latest docs from google until just now. These are all tip of tree docs so subject to change. Unfortunately just no enabling interception will mean that the authentication parts of hpdf will not work (I think). I've gotta get to work atm but will look asap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
Network.setRequestInterceptionEnabled-->Network.setRequestInterceptionin HPDF.Printer.This is change from Chromium r511134, if i understood it correctly. Anyway,
Network.setRequestInterceptionEnabledis no more and causes printing PDF to fail.