This repository was archived by the owner on Mar 26, 2025. It is now read-only.
Conversation
grutt
approved these changes
Jan 16, 2025
Contributor
grutt
left a comment
There was a problem hiding this comment.
Not sure why we were doing this... I'm in favor of removing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review with whitespace hidden, the diff is much smaller than GH thinks
Fixing Tenacity logic for retries here - there were a couple of issues:
grpcwill raise agrpc.RpcErrorvs when it will raisegrpc.aio.AioRpcError(I'd think that when usingaiomethods it'd raise anaioerror, but from local testing that appears to not be the case. So I just am catching both cases everywhere for now.isinstance(ex, (grpc.aio.AioRpcError, grpc.RpcError))check to fail, making the errors fall through and not be retried. In those cases, I removed the error handling in the function that had retries enabled (cc @grutt lmk if there's a reason I'm missing for doing this - want to make sure I'm not breaking something unintentionally)ex.codeis a method, so theif ex.code in [...]check would always be falsy regardless of the code, so I fixed that