This repository was archived by the owner on Mar 26, 2025. It is now read-only.
Proposal: Remove aio_client from admin client#314
Closed
Conversation
Contributor
Author
|
Closing b/c breaking changes needed, will put this in the v2 sdk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
aio_clienton theAdminClientseems to just have a bunch of duped code that replaces the original gRPC client with the async one, which also causes problems when usingasyncio.run(or other cases with existing event loops, like in Pytest). Proposal here is to replace it with a call toasyncio.to_threadon the sync methods like we do in the event client.