limit fifo read size to ep_bufsize regardless ep_buf is used or not #3424
+1
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: HiFiPhile <admin@hifiphile.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the CFG_TUD_CDC_EP_BUFSIZE configuration was not being respected for devices using hardware FIFO. The fix removes a conditional check that incorrectly prevented the endpoint buffer size limit from being applied when ep_buf is NULL (hardware FIFO mode), ensuring consistent behavior for all devices regardless of whether they use a dedicated endpoint buffer or hardware FIFO.
Key Changes
- Removed conditional check for
ep_buf != NULLthat preventedep_bufsizefrom limiting transfer size in hardware FIFO mode - Ensures
CFG_TUD_CDC_EP_BUFSIZEsetting is effective for all device configurations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Size Difference ReportBecause TinyUSB code size varies by port and configuration, the metrics below represent the averaged totals across all example builds. Note: If there is no change, only one value is shown. Changes >1% in sizeNo entries. Changes <1% in size
No changes
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
I've added
if (s->ep_buf != NULL) {during the fixup but it will break receiving behavior when the host can't send ZLP. With thisifadded settingCFG_TUD_CDC_EP_BUFSIZEwill no longer have effect on devices using HWFIFO.Related to #2287