Implement Printer Device Driver #3444
Draft
+1,133
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (!_printer_fifo_cfg.tx_persistent) { | ||
| tu_fifo_clear(&p_printer->tx_ff); | ||
| } | ||
| // tu_fifo_set_overwritable(&p_printer->rx_ff, true); |
Check notice
Code scanning / CodeQL
Commented-out code Note
I apparently made a mistake when copying/renaming this file, file content was that of printer_device.c.
Author
|
Well I apparently made (at least) one major mistake when moving the code from my local project to the repository fork. The content of printer.h and printer_device.c is the same, leading to (part of) the compilation errors. I'll work on that and the other problems raised by the CI pipeline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Implement a printer device driver for USB Printers. The example illustrates receiving data from a host, the device driver as-is is recognized by the generic printer drivers on linux (and I assume, Windows too).
This allows sending binary data to the device, with no specific drivers, using tools like
ld -o raw.Additional context
The example compiles and works on a Pi Pico.
I am not yet sure about integration of the changes in the build toolchain. I have not yet understood if I have to manually edit all the
hw/{bsp,mcu}/file to include the device driver in cmake source lists.