chore(tests): prepare testing setup for http2 and https#190
Merged
Conversation
Member
Author
|
Looks like Windows can't cleanly close the HTTP/2 connection and Node 18 seems picky about uwebSocket's SSL implementation too. Let's try to address those one by one 😅 |
cyco130
force-pushed
the
chore/http2-tests
branch
3 times, most recently
from
e6e0234 to
6a7669d
Compare
Member
Author
|
I disabled "uwebSockets.js with SSL" tests on Node 18. We only support Node 18 for StackBlitz and StackBlitz will switch to v20 soon. And it can't run I opened a separate issue for the Windows failure. I don't have a Windows machine and it's almost impossible for me to investigate. Also, I have a suspicion that it is related to my fetch implementation rather than the adapter. No need to block this as we're not breaking anything that wasn't already broken. |
cyco130
force-pushed
the
chore/http2-tests
branch
from
6a7669d to
7640aab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds alternative
fetchimplementations to be used for testing HTTPS and HTTP/2 adapters. It also adds a few lines to make the standard Node adapter work withnode:http2correctly (except for the types).This should allow testing #185 as well. I've already added an HTTP/2 test (using the standard Node adapter). The types don't match but all tests are passing. It might still take some work to make sure everything works as expected though.
Also added
node:httpsand "uwebsockets.jswith SSL" tests.