fix(adapter-test): loosen env argument for easy process.env forwarding#201
Open
aleclarson wants to merge 3 commits intohattipjs:mainfrom
Open
fix(adapter-test): loosen env argument for easy process.env forwarding#201aleclarson wants to merge 3 commits intohattipjs:mainfrom
env argument for easy process.env forwarding#201aleclarson wants to merge 3 commits intohattipjs:mainfrom
Conversation
The `AdapterRequestContext#env` method uses this interface to provide type safety at compile-time. It allows the user to make certain assumptions about the existence of particular environment variables.
…passed without type assertion
aleclarson
commented
Feb 4, 2025
| }, | ||
| env(variable) { | ||
| return env[variable]; | ||
| return env[variable] as any; |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While
process.env(from@types/node) hasRecord<string, string | undefined>type, theenvargument of@hattip/adapter-testexpects aRecord<string, string>type. I believe this is more strict than necessary. It'd be great to be able to passprocess.envin without a type assertion.Note: This builds upon #197 and so that PR should be merged first. Only this commit is relevant to this PR.