add menu:create_page(page_size, page_no)#293
Open
shewer wants to merge 3 commits intohchunhui:masterfrom
Open
Conversation
CandidateList menu:create_page(page_size, page_no)
```lua
local seg = ctx.composition:back()
local cands = seg and seg.menu
and seg.menu:create(5,0)
cands = cands or {}
for _, cand in ipairs(cands) do print(cand.text) end
```
hchunhui
reviewed
Jan 20, 2024
src/types.cc
Outdated
|
|
||
| CandidateList create_page(T& t, size_t page_size, size_t page_no) { | ||
| if (auto p = an<Page>( t.CreatePage(page_size, page_no)) ) { | ||
| return p->candidates; |
Owner
There was a problem hiding this comment.
返回了一个局部 shared_ptr 的成员，可能要论证一下是否有内存方面的问题
改回原式 井 手動刪除 Paeg 記憶體
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CandidateList menu:create_page(page_size, page_no)