Wrap Translation::Peek() and Translation::Next()#352
Open
ksqsf wants to merge 2 commits intohchunhui:masterfrom
Open
Wrap Translation::Peek() and Translation::Next()#352ksqsf wants to merge 2 commits intohchunhui:masterfrom
ksqsf wants to merge 2 commits intohchunhui:masterfrom
Conversation
Contributor
Contributor
Author
|
i see. 不过我不太赞同「有了 iter 就不要其他接口」。比如想抛弃 sentence 的时候,如果有 peek,我可以保留其他代码,而不用引入别的代码。 if tran:peek() and tran:peek().type == "sentence" then
tran:next()
end
-- other logic
yield(cand1)
yield(cand2)
--
for cand in tran:iter() do
yield(cand)
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
有的时候只需要简单地查看前一两个候选,直接使用 Peek() 和 Next() 会比 iter() 方便一点。