-
Notifications
You must be signed in to change notification settings - Fork 4
Allow customize alias title field #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds the ability to customize the title field used for alias generation in the AliasFieldConfiguration class. Previously, the system always used the hardcoded 'title' field; now developers can specify an alternative field via the new setTitleField() method.
Changes:
- Added
titleFieldproperty andsetTitleField()method toAliasFieldConfigurationfor customizing the source field for alias generation - Renamed
aliasExistCallbacktogenerateAliasCallbackfor better naming consistency, with backward compatibility through a deprecated method - Updated dependency version constraints to support Symfony 7.0 and Doctrine DBAL 4.0
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Dca/AliasFieldConfiguration.php | Adds titleField property and setter method, renames callback property for clarity |
| src/EventListener/DcaField/AliasDcaFieldListener.php | Implements support for custom title field in alias generation logic, adds Contao 4/5 compatibility |
| src/Util/UserUtil.php | Removes unused imports (contains critical error) |
| src/EntityFinder/Finder.php | Removes obsolete phpstan ignore comment |
| src/EntityFinder/EntityFinderHelper.php | Fixes trailing newline formatting |
| rector.php | Updates configuration with better formatting and additional options |
| composer.json | Updates dependency versions for Symfony 7.0 and Doctrine DBAL 4.0 support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pull Request Test Coverage Report for Build 21216089235Details
💛 - Coveralls |
No description provided.