Skip to content

Conversation

@heimrich-hannot
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings January 21, 2026 13:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the ability to customize the title field used for alias generation in the AliasFieldConfiguration class. Previously, the system always used the hardcoded 'title' field; now developers can specify an alternative field via the new setTitleField() method.

Changes:

  • Added titleField property and setTitleField() method to AliasFieldConfiguration for customizing the source field for alias generation
  • Renamed aliasExistCallback to generateAliasCallback for better naming consistency, with backward compatibility through a deprecated method
  • Updated dependency version constraints to support Symfony 7.0 and Doctrine DBAL 4.0

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
src/Dca/AliasFieldConfiguration.php Adds titleField property and setter method, renames callback property for clarity
src/EventListener/DcaField/AliasDcaFieldListener.php Implements support for custom title field in alias generation logic, adds Contao 4/5 compatibility
src/Util/UserUtil.php Removes unused imports (contains critical error)
src/EntityFinder/Finder.php Removes obsolete phpstan ignore comment
src/EntityFinder/EntityFinderHelper.php Fixes trailing newline formatting
rector.php Updates configuration with better formatting and additional options
composer.json Updates dependency versions for Symfony 7.0 and Doctrine DBAL 4.0 support

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coveralls
Copy link

coveralls commented Jan 21, 2026

Pull Request Test Coverage Report for Build 21216089235

Details

  • 12 of 13 (92.31%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 78.93%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/EventListener/DcaField/AliasDcaFieldListener.php 9 10 90.0%
Totals Coverage Status
Change from base Build 20129291482: 0.2%
Covered Lines: 1165
Relevant Lines: 1476

💛 - Coveralls

@koertho koertho merged commit 177cb2e into v3 Jan 21, 2026
15 checks passed
@koertho koertho deleted the feature/alias_custom_title branch January 21, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants