Skip to content

Conversation

@jtniehof
Copy link
Contributor

This is a terrible first shot at displaying approved pheps, by someone who really doesn't understand Jekyll :) but hopefully it can get the idea across. It's sort of the complement to heliophysicsPy/standards#26 ...that has a Python snippet which extracts the necessary yaml, and this then just dumps the YAML, more-or-less. Untested.

Maybe we should have the DOI in there somewhere, too.

@sapols
Copy link
Contributor

sapols commented Apr 16, 2024

Apparently the liquid conditional logic isn't gonna let us do that or, so my latest commit, while uglier in code, is needed to fix the display. With that fix the page now displays like:
Screen Shot 2024-04-16 at 4 40 44 PM

Calling that a stopping point. I'll continue working on this in the morning.

(And I'll note I intend to move this under a subpage of Documents rather than adding a PHEPs nav bar item.)

@jtniehof
Copy link
Contributor Author

That's probably actually more clear. Thanks for getting that working. I'll poke around and see what I can do about including DOI.

@jtniehof
Copy link
Contributor Author

I just pushed an update to heliophysicsPy/standards#26 that inserts the DOI into the YAML, so we will want an additional column. I'm thinking at the very end (after revision) and then:

          <td>
            <a href="https://doi.org/{{ phep.DOI }}">doi:{{ phep.DOI }}</a>
          </td>

@sapols
Copy link
Contributor

sapols commented Apr 17, 2024

I'll note that for the DOI to display properly in the table, the DOI entry in the yaml should look like 10.5281/zenodo.10988007 (e.g. don't include http:// in that entry).

@sapols
Copy link
Contributor

sapols commented Apr 17, 2024

Render with the DOI column:
Screen Shot 2024-04-17 at 11 42 05 AM

@jtniehof jtniehof changed the title Initial hack at displaying approved PHEPs Displaying approved PHEPs; include PHEP-1 May 20, 2024
@jtniehof
Copy link
Contributor Author

Just to note, once heliophysicsPy/standards#22 is merged and the release cut, I will finish the Zenodo upload and mark this ready to merge.

@jtniehof jtniehof marked this pull request as ready for review May 20, 2024 22:28
@jtniehof
Copy link
Contributor Author

Zenodo is uploaded, so @sapols , ready to merge!

@sapols sapols merged commit 0c90230 into heliophysicsPy:main May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants