FileStorePoller prefix filtering #1108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldjeffrey
requested review from
bbalser,
connormck333,
dcyoung,
jeffgrunewald,
kurotych and
macpie
connormck333
approved these changes
Dec 17, 2025
- makes `.run()` method `pub` so we can use it in a test - adds `aws-local` as a dev-dependency
With the addition of `radio_usage_stats_ingest_report_v2` we have our first
overlapping file prefix.
When polling for older `radio_usage_stats_ingest_report` files, both files
are returned in the list when we don’t want them to be.
```
RadioUsageStatsIngestReport => "radio_usage_stats_ingest_report",
RadioUsageStatsIngestReportV2 => "radio_usage_stats_ingest_report_v2”,
```
Appending a `.` to the provided prefix will force an exclusive match that
still respects the `FileInfo` regex pattern of `{prefix}.{time}.gz`.
If you want to make a Poller that matches on multiple files with the
same prefix, you can still do that with
`FileInfoPollerBuilder::prefix_without_dot()`.
michaeldjeffrey
force-pushed
the
mj/file-store-prefix-append-dot
branch
from
a592d62 to
7f6cff6
Compare
dcyoung
approved these changes
Dec 17, 2025
Clients were being created with the same credentials for all tests. Because the `CLIENT_CACHE` is `static` it is shared for the duration of all tests being run. So every test would have the same client. When a tests finished and dropped it’s client while other tests were still in flight, the dispatcher would no longer exist and we would get an error. This fix causes every test to get a fresh client.
bbalser
approved these changes
Dec 18, 2025
`_list_files` was broken out to be able to specifically test the functionality of `.set_start_after()`. Previously, the tests were passing because of the later filters on timestamp after a returned s3 object was turned into a `FileInfo`. The entire history of files was being returned and filtered as a side effect.
michaeldjeffrey
force-pushed
the
mj/file-store-prefix-append-dot
branch
from
b6e34d6 to
2b01fd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of
radio_usage_stats_ingest_report_v2we have our first overlapping file prefix.When polling for older
radio_usage_stats_ingest_reportfiles, both files are returned in the list when we don’t want them to be.Appending a
.to the provided prefix will force an exclusive match that still respects theFileInforegex pattern of{prefix}.{time}.gz.If you want to make a Poller that matches on multiple files with the same prefix, you can still do that with
FileInfoPollerBuilder::prefix_without_dot()..run()methodpubso we can use it in a testaws-localas a dev-dependencyFix intermittent "dispatch task is gone" in tests
Clients were being created with the same credentials for all tests.
Because the
CLIENT_CACHEisstaticit is shared for the duration ofall tests being run. So every test would have the same client. When a
tests finished and dropped it’s client while other tests were still in
flight, the dispatcher would no longer exist and we would get an error.
This fix causes every test to get a fresh client.