pull the code a bit up to nowadays#20
Open
erwinkinn wants to merge 1 commit intohellysmile:masterfrom
Open
Conversation
Collaborator
Author
|
Hei ;) Is it something wrong with the PR? It's taking long for some reasons... |
|
@hellysmile please merge and realease this update as the module breaks in Python 3.11+ |
|
@erwinkinn I'm aware it's been years, but could you please comment on this bit: # Note no async_timeout shortcuts here
# because we must keep a loop passed from the outside.
async with async_timeout.Timeout(
_loop.time() + timeout,
loop=_loop,
):Why is it important to keep passing the loop? And also note the async_timeout library's Moreover, what's the reason for even providing the possibility of passing asyncio loops to retry()? |
laur89
added a commit
to laur89/async-retry-deco
that referenced
this pull request
Oct 30, 2025
- note there are still unanswered questions regarding the event loop that's being passed around, see comment @ hellysmile#20 (comment)
laur89
added a commit
to laur89/async-retry-deco
that referenced
this pull request
Oct 30, 2025
- note there are still unanswered questions regarding the event loop that's being passed around, see comment @ hellysmile#20 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These is quite all I want to edit till the moment.
asyncio.coroutinedecoratorasync_timeoutversion supportpytest_asynciopluginblackmypy.If it's ok it would be nice to get it at pypi as well ;)