fix: handle OCI digest algorithm prefix in chart downloader #31601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/M
banjoh
changed the title
OCI references with tag+digest (e.g., chart:1.0@sha256:abc...) failed with "invalid byte" error because the sha256: prefix was passed to hex.DecodeString(). Signed-off-by: Evans Mungai <mbuevans@gmail.com>
banjoh
force-pushed
the
em/fix-digest-tag-inconsistency
branch
from
a8697d7 to
c5112b9
Compare
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
pull-request-size
bot
added
size/L
TerryHowe
reviewed
Dec 3, 2025
pkg/repo/v1/repotest/server.go
Outdated
| TestUsername string | ||
| TestPassword string | ||
| Client *ociRegistry.Client | ||
| ManifestDigest string // Digest of the pushed oci-dependent-chart manifest |
Contributor
There was a problem hiding this comment.
This is a bit odd to put ManifestDigest here in a object about server configuration. There's no other way to validate?
Contributor
Author
There was a problem hiding this comment.
Agreed! I'll see how best to do this
Contributor
|
Thanks for pulling to PR together so fast @banjoh ! |
Signed-off-by: Evans Mungai <mbuevans@gmail.com>
TerryHowe
added
the
Has One Approval
gjenkins8
reviewed
Dec 22, 2025
Comment on lines
+520
to
+522
| if result != tt.expected { | ||
| t.Errorf("stripDigestAlgorithm(%q) = %q, want %q", tt.input, result, tt.expected) | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if result != tt.expected { | |
| t.Errorf("stripDigestAlgorithm(%q) = %q, want %q", tt.input, result, tt.expected) | |
| } | |
| assert.Equal(t, tt.expected, result) |
Use testify?
gjenkins8
reviewed
Dec 22, 2025
| } | ||
|
|
||
| func TestStripDigestAlgorithm(t *testing.T) { | ||
| tests := []struct { |
Member
There was a problem hiding this comment.
use a map here? e.g.
tests := map[string]struct {
input string
expected string
}{
"sha256 prefixed digest": {
input: "...
Then below:
for name, tt := range tests {
t.Run(name, func(t *testing.T) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
OCI references with tag+digest (e.g.,
chart:1.0@sha256:abc...) failed with "invalid byte" error because thesha256:prefix was passed tohex.DecodeString().Closed: #31600
Special notes for your reviewer:
If applicable:
docs neededlabel should be applied if so)