Skip to content

fix: shortcodes rendering module view twice #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NiclasNorin merged 3 commits into from
Sep 18, 2025
Merged

fix: shortcodes rendering module view twice #901

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c41bbb8
fix: shortcodes rendering module view twice
NiclasNorin Jun 26, 2025
79b3a5d
fix: setting cache
NiclasNorin Jun 26, 2025
1b5ade2
Merge branch 'main' into fix/shortcode-rendering-module-twice
NiclasNorin Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions source/php/Display.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,8 @@ class Display
public $options = null;
private $isBlock = false;
private $isRenderingModule = false;
private static $renderedShortcodeModules = [];
private $isShortcode = false; // Flag to indicate if the current context is a shortcode.


private static $sidebarState = []; //Holds state of sidebars.

public function __construct()
Expand Down Expand Up @@ -767,6 +766,10 @@ public function shortcodeDisplay($args)
return;
}

if (isset(self::$renderedShortcodeModules[$args['id']])) {
return self::$renderedShortcodeModules[$args['id']];
}

//Get module details
$module = \Modularity\Editor::getModule($args['id']);

Expand All @@ -788,9 +791,11 @@ public function shortcodeDisplay($args)

$moduleMarkup = apply_filters('Modularity/Display/Markup', $moduleMarkup, $module);
$moduleMarkup = apply_filters('Modularity/Display/' . $module->post_type . '/Markup', $moduleMarkup, $module);
$moduleMarkup = '<div class="' . $module->post_type . '">' . $moduleMarkup . '</div>';

self::$renderedShortcodeModules[$args['id']] = $moduleMarkup;
$this->isShortcode = false;
return '<div class="' . $module->post_type . '">' . $moduleMarkup . '</div>';
return $moduleMarkup;
}

/**
Expand Down